-
Notifications
You must be signed in to change notification settings - Fork 90
Upgrade thirdweb to v5.100.1 and update UserOp handling for gas overrides #894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We're building your pull request over on Zeet. |
WalkthroughThe dependency version for "thirdweb" in Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant Worker
participant AccountContract
participant FactoryContract
participant ThirdwebClient
Caller->>Worker: Invoke _sendUserOp(job)
Worker->>AccountContract: (If needed) Call factory() to get factory address
AccountContract-->>Worker: Return factory address or error
Worker->>FactoryContract: (If needed) Call entrypoint() to get entrypoint address
FactoryContract-->>Worker: Return entrypoint address or error
Worker->>ThirdwebClient: prepareUserOp(...)
ThirdwebClient-->>Worker: Return prepared user operation or error
alt Gas fee override check
Worker-->>Caller: Delay job (if override too low)
else
Worker->>ThirdwebClient: signUserOp(...)
ThirdwebClient-->>Worker: Return signed user operation or error
Worker->>ThirdwebClient: bundleUserOp(...)
ThirdwebClient-->>Worker: Return bundled result or error
Worker-->>Caller: Return sent transaction or error
end
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
PR-Codex overview
This PR updates the
thirdweb
package version and modifies thesend-transaction-worker.ts
file to enhance the transaction handling process by adding new types and improving user operation preparation and signing.Detailed summary
thirdweb
from5.96.5
to^5.100.1
inpackage.json
.DelayedError
import frombullmq
.Address
,Chain
,ThirdwebClient
, andVersionedUserOp
.handler
function to accept an optionaltoken
parameter._sendUserOp
to includetoken
in transaction sending.getEntrypointFromFactory
function to retrieve entrypoint addresses.Summary by CodeRabbit